Fixed issue with margin of SplitButton not being applied as margin correctly#3831
Merged
Keboo merged 1 commit intoMaterialDesignInXAML:masterfrom Apr 15, 2025
Conversation
nicolaihenriksen
approved these changes
Apr 15, 2025
Contributor
nicolaihenriksen
left a comment
nicolaihenriksen
left a comment
There was a problem hiding this comment.
Was a little curious about some edge cases, but it does seem to work as intended for the ones I tested. Nice work.
Keboo
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a margin to the SplitButton I got the following unexpected result:
With this PR the margins will be applied similar as they would for a normal button.